PBL-38362 CloudPebble YCMD proxy outputs many spurious logs #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spacerat
force-pushed
the
bugfix/no-pointless-ycmd-requests
branch
from
2f5ae91
to
633195e
Compare
Spacerat
changed the title
Spacerat
force-pushed
the
bugfix/no-pointless-ycmd-requests
branch
from
633195e
to
7dbc3b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YCMD complains and outputs a bunch of useless error logs when you attempt to ask for completions while typing comments. It also never returns any line-errors for files shorter than 6 lines.
This adds some checks to prevent the requests, which should also help reduce pointless bandwidth usage too.